Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): make sure replica receives a block #52

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Oct 17, 2024

Send a simple tx to replica before running tests. This would add it to the pool and await replica receiving a block with this transaction, thus flipping the prague fork activation here https://github.com/paradigmxyz/reth/blob/0a1473b6e7949875f480043fa6874bdc583786d2/crates/transaction-pool/src/validate/eth.rs#L467

This is a workaround until we figure out why replica is not able to receive blocks from sequencer over p2p right away after the launch

Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's create a tracking issue for the underlying cause?

@onbjerg onbjerg added the bug Something isn't working label Oct 17, 2024
@onbjerg onbjerg merged commit 38a6965 into ithacaxyz:main Oct 17, 2024
14 checks passed
@mattsse
Copy link
Member

mattsse commented Oct 17, 2024

thus flipping the prague fork activation here

I'd consider this pool initialization issue, tracking on reth, this will naturally go away once we set this as activated by default

onbjerg pushed a commit that referenced this pull request Oct 24, 2024
Uses https://github.com/ethpandaops/optimism-package directly and
updates README a bit as we no more need to build contract deployer image
separately

Also removed hack from #52 as
it shouldn't be needed after
paradigmxyz/reth#11847
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants